Merged
Conversation
clintjedwards
approved these changes
Apr 29, 2026
Contributor
clintjedwards
left a comment
clintjedwards
left a comment
There was a problem hiding this comment.
If I had a nickel for the amount of times I wrote something with file paths and then had to go back to fix a really confusing error because of relative paths;
I wouldn't be rich, but I would have a lot of nickels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was recently messing around with
DomainMapand the routes file watching wasn't working, and after tearing up the carpet it turned out it was because I used a relative path as input. This was breaking the underlyingFileWatcher's path comparisons. Currently we always provide an absolute path toDomainMap, but I figure it would be good to updateFileWatcherto support relative paths to avoid such surprises. This PR does this by internally canonicalizing the parent path.