Skip to content

Conversation

@philippschulte
Copy link
Member

Change summary

This PR adds an acceptance test to verify that configuration changes to the ngwaf block within the product_enablement attribute of the fastly_service_vcl resource are correctly applied and do not result in persistent diffs.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
  • Post the output of your test runs
=== RUN   TestAccFastlyServiceVCLProductEnablement_basic
=== PAUSE TestAccFastlyServiceVCLProductEnablement_basic
=== CONT  TestAccFastlyServiceVCLProductEnablement_basic
--- PASS: TestAccFastlyServiceVCLProductEnablement_basic (16.11s)
=== RUN   TestAccFastlyServiceVCLProductEnablement_ngwafUpdate
=== PAUSE TestAccFastlyServiceVCLProductEnablement_ngwafUpdate
=== CONT  TestAccFastlyServiceVCLProductEnablement_ngwafUpdate
--- PASS: TestAccFastlyServiceVCLProductEnablement_ngwafUpdate (46.63s)

@philippschulte philippschulte requested a review from a team as a code owner November 19, 2025 04:38
@philippschulte philippschulte added the Skip-Changelog Skip changelog build check label Nov 19, 2025
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this covers the necessary changes. I could have sworn that NGWAF had a mode attribute like DDoS Protection does but I don't see it in the API reference.

@philippschulte philippschulte merged commit 069af7e into fastly:main Nov 19, 2025
23 checks passed
@philippschulte philippschulte deleted the pschulte/add-acceptance-test-for-ngwaf-configuration-updates branch November 19, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Changelog Skip changelog build check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants