Fix SortGraph Removes Nodes Connected only to I/O#189
Merged
Conversation
Collaborator
|
Thanks @jsmonson for catching this! Adding a screenshot of the testcase raising the bug when the fix is not applied for reference sake: Before: After: |
maltanar
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes a bug in the SortGraph transformation that removes nodes (that should be kept) that were only connected to graph inputs and outputs. The fix inserts code that checks for the node inputs for a connection to a graph input or initializer. If one is found than it inserts an empty dependency to prevent the node from being removed from the graph.