Use weight shape as backup if kernel_shape attribute doesn't exist#202
Closed
jmitrevs wants to merge 1 commit intofastmachinelearning:mainfrom
Closed
Use weight shape as backup if kernel_shape attribute doesn't exist#202jmitrevs wants to merge 1 commit intofastmachinelearning:mainfrom
jmitrevs wants to merge 1 commit intofastmachinelearning:mainfrom
Conversation
Collaborator
Author
|
The suggestion is that this should be fixed in the alternate way, always making sure that kernel_shape is set in our version of Conv. I will try to make an alternate fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Conv nodes aren't required to have a "kernel_shape" attribute, this use the weight input shape as a backup also in our custom up. I believe the behavior should be the same as for standard Conv. Please check if the logic is correct.