Add AnalysisPass base class - #242
Open
bwintermann wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While documenting our code (@LinusJungemann) stumbled over the fact that analysis passes are simply functions that should implicitly adhere to a calling convention. Mirroring the
Transformationbase class, this PR introduces anAnalysisPassbase class, which one can implement. This defines a nicer interface and additionally enables stateful analysis passes.The matching
ModelWrapper.analysismethod stays backwards compatible, checking the type of the analysis function before executing it.The
qonnx/analysis/base.pymodule docstring was adjusted and an additional test was introduced. All existing analysis-related tests pass.(There are some unrelated edits made by the pre-commit hook.)