Open
Conversation
|
This would be very helpful. With Squire 1.x it was possible to extend Squire, but with 2.x rewrite the internal method are not accessible anymore (not exported) and this makes extending very complicated (e.g. getBlockWalker, empty). Also the source is not included in package. |
Contributor
Author
|
@neilj Hi! Are there any plans to include this feature in lib? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found it very useful to use this function to set header tags (e.g. h1, h2, h3).
To be clear, it's your @neilj example from this PR.
If this type of method doesn't fit to the Squire's philosophy or plans right now, then could we expose couple "private" methods so we can build more upon the Squire (the best open-source editor out there imho) and not patch anything.