fix(desktop): restore meeting auto-stop fallback#5439
fix(desktop): restore meeting auto-stop fallback#5439ComputelessComputer wants to merge 1 commit into
Conversation
✅ Deploy Preview for old-char canceled.
|
Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.
ca87089 to
a9fb137
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a9fb137. Configure here.
| candidateAppIds, | ||
| payload.apps, | ||
| stoppedTriggerAppIds.length === 0, | ||
| ); |
There was a problem hiding this comment.
Non-trigger mic event can downgrade pending auto-stop confidence
Medium Severity
When a trigger app stops mic, a timer starts with requireMicSnapshot = false (high confidence). If a non-trigger app then stops within the 5-second window, clearPendingAutoStop() cancels that timer and starts a new one with requireMicSnapshot = true (lower confidence). If listMicUsingApplications subsequently fails, the recording won't stop — even though there was direct evidence from the first event that the trigger app stopped. The unconditional clearPendingAutoStop() call loses the stronger guarantee from the original event.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a9fb137. Configure here.


Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.
Note
Medium Risk
Changes when recordings stop during meetings; fallback path adds requireMicSnapshot but incorrect auto-stop could still affect user sessions.
Overview
Meeting auto-stop now runs when
micStoppedonly reports helper processes (e.g.pid:Teams helpers) instead of the real trigger bundle ID, by falling back to the stored trigger app IDs viagetAutoStopCandidateAppIdsand the updatedconfirmAutoStopflow.On that fallback path, auto-stop aborts if
listMicUsingApplicationsfails (requireMicSnapshot), but still bails out when any candidate trigger is still on the mic. The browser allowlist was renamed toBROWSER_AUTO_STOP_APP_IDSand expanded (Aside, Helium, Tor, more Chromium variants, etc.) for calendar early-end prompts.Tests cover #5436 (Teams helper / browser trigger), non-trigger
micStoppedwith an active trigger, and parameterized “ask before stopping” for multiple browsers.Reviewed by Cursor Bugbot for commit a9fb137. Bugbot is set up for automated code reviews on this repo. Configure here.