Skip to content

fix(desktop): restore meeting auto-stop fallback#5439

Open
ComputelessComputer wants to merge 1 commit into
mainfrom
fix/meeting-auto-stop-trigger-fallback
Open

fix(desktop): restore meeting auto-stop fallback#5439
ComputelessComputer wants to merge 1 commit into
mainfrom
fix/meeting-auto-stop-trigger-fallback

Conversation

@ComputelessComputer
Copy link
Copy Markdown
Collaborator

@ComputelessComputer ComputelessComputer commented Jun 2, 2026

Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.


Note

Medium Risk
Changes when recordings stop during meetings; fallback path adds requireMicSnapshot but incorrect auto-stop could still affect user sessions.

Overview
Meeting auto-stop now runs when micStopped only reports helper processes (e.g. pid: Teams helpers) instead of the real trigger bundle ID, by falling back to the stored trigger app IDs via getAutoStopCandidateAppIds and the updated confirmAutoStop flow.

On that fallback path, auto-stop aborts if listMicUsingApplications fails (requireMicSnapshot), but still bails out when any candidate trigger is still on the mic. The browser allowlist was renamed to BROWSER_AUTO_STOP_APP_IDS and expanded (Aside, Helium, Tor, more Chromium variants, etc.) for calendar early-end prompts.

Tests cover #5436 (Teams helper / browser trigger), non-trigger micStopped with an active trigger, and parameterized “ask before stopping” for multiple browsers.

Reviewed by Cursor Bugbot for commit a9fb137. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 2, 2026

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit a9fb137
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a1e3eae2a9db00008bb8789

Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.
@ComputelessComputer ComputelessComputer force-pushed the fix/meeting-auto-stop-trigger-fallback branch from ca87089 to a9fb137 Compare June 2, 2026 02:23
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a9fb137. Configure here.

candidateAppIds,
payload.apps,
stoppedTriggerAppIds.length === 0,
);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-trigger mic event can downgrade pending auto-stop confidence

Medium Severity

When a trigger app stops mic, a timer starts with requireMicSnapshot = false (high confidence). If a non-trigger app then stops within the 5-second window, clearPendingAutoStop() cancels that timer and starts a new one with requireMicSnapshot = true (lower confidence). If listMicUsingApplications subsequently fails, the recording won't stop — even though there was direct evidence from the first event that the trigger app stopped. The unconditional clearPendingAutoStop() call loses the stronger guarantee from the original event.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a9fb137. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant