fix(desktop): restore meeting auto-stop fallback#5439
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
ca87089 to
a9fb137
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a9fb137. Configure here.
Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.
Keep direct trigger-stop timers from being downgraded by later helper-only micStopped events, and cover the failed mic snapshot regression.
c09c2cb to
5209719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.
Note
Medium Risk
Changes live recording stop behavior on mic events; mistakes could stop sessions early or leave them running, but logic is guarded by mic snapshots and existing calendar prompts.
Overview
Meeting auto-stop now treats
micStoppedmore reliably when the OS reports helper/PID processes instead of the real trigger app (e.g. Teams, browser-based meetings). A newgetAutoStopCandidateAppIdspath uses the full trigger list when the stopped app list doesn’t include the trigger bundle id, while still re-checking the mic snapshot so a still-active trigger isn’t stopped on unrelated stops.Pending auto-stop timers track whether a mic snapshot is required; weaker helper-only events won’t downgrade a timer started from a direct trigger stop, and snapshot failures block stop only when that stricter path applies.
The browser bundle-id set is expanded and renamed (
BROWSER_AUTO_STOP_APP_IDS) for calendar early-end prompts and primary stopped-app labeling. Tests cover regressions #5436 / helper behavior and parameterize early-end prompts across multiple browsers.Reviewed by Cursor Bugbot for commit 5209719. Bugbot is set up for automated code reviews on this repo. Configure here.