Skip to content

fix(desktop): restore meeting auto-stop fallback#5439

Merged
ComputelessComputer merged 2 commits into
mainfrom
fix/meeting-auto-stop-trigger-fallback
Jun 2, 2026
Merged

fix(desktop): restore meeting auto-stop fallback#5439
ComputelessComputer merged 2 commits into
mainfrom
fix/meeting-auto-stop-trigger-fallback

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.


Note

Medium Risk
Changes live recording stop behavior on mic events; mistakes could stop sessions early or leave them running, but logic is guarded by mic snapshots and existing calendar prompts.

Overview
Meeting auto-stop now treats micStopped more reliably when the OS reports helper/PID processes instead of the real trigger app (e.g. Teams, browser-based meetings). A new getAutoStopCandidateAppIds path uses the full trigger list when the stopped app list doesn’t include the trigger bundle id, while still re-checking the mic snapshot so a still-active trigger isn’t stopped on unrelated stops.

Pending auto-stop timers track whether a mic snapshot is required; weaker helper-only events won’t downgrade a timer started from a direct trigger stop, and snapshot failures block stop only when that stricter path applies.

The browser bundle-id set is expanded and renamed (BROWSER_AUTO_STOP_APP_IDS) for calendar early-end prompts and primary stopped-app labeling. Tests cover regressions #5436 / helper behavior and parameterize early-end prompts across multiple browsers.

Reviewed by Cursor Bugbot for commit 5209719. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Jun 2, 2026

Copy link
Copy Markdown

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 5209719
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a1e759bbac43800081eb490

@ComputelessComputer ComputelessComputer force-pushed the fix/meeting-auto-stop-trigger-fallback branch from ca87089 to a9fb137 Compare June 2, 2026 02:23

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a9fb137. Configure here.

Comment thread apps/desktop/src/stt/contexts.tsx Outdated
Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.
Keep direct trigger-stop timers from being downgraded by later helper-only micStopped events, and cover the failed mic snapshot regression.
@ComputelessComputer ComputelessComputer force-pushed the fix/meeting-auto-stop-trigger-fallback branch from c09c2cb to 5209719 Compare June 2, 2026 06:18
@ComputelessComputer ComputelessComputer merged commit 35bfe27 into main Jun 2, 2026
10 checks passed
@ComputelessComputer ComputelessComputer deleted the fix/meeting-auto-stop-trigger-fallback branch June 2, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant