fix(tray): derive version channel from bundle id#5290
Merged
Conversation
Use the app identifier for tray channel detection and keep product-name fallback coverage for legacy configs.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the app identifier for tray channel detection and keep product-name fallback coverage for legacy configs.
Note
Low Risk
Low risk: changes only how the tray version label derives its release channel and adds unit tests; impact is limited to displayed text in the tray menu.
Overview
The tray version menu item now derives the release channel primarily from the app bundle identifier (
app.config().identifier) instead of only the product name, with a fallback to the previous name-based mapping for unknown identifiers.Adds unit tests covering identifier-based channel detection and the legacy product-name fallback.
Reviewed by Cursor Bugbot for commit 9cd9b0b. Bugbot is set up for automated code reviews on this repo. Configure here.