fix(desktop): refine chat panel chrome#5430
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c5cdcd. Configure here.
| return null; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Centered panel breaks edge resize
Medium Severity
The floating chat frame now centers the panel with justify-center, but getResizedSize still applies edge-based width and height deltas as if one side stays fixed. Dragging the left, right, or top corner handles changes size while the panel re-centers, so the edge under the pointer no longer tracks the drag.
Reviewed by Cursor Bugbot for commit 9c5cdcd. Configure here.
Use the modal dark surface for the docked chat panel, remove its outer side inset and top border, square its top-left corner, match the note header height, fix the docked panel icon button, balance the right-panel chat internal spacing, and collapse chat when opening settings.
ComputelessComputer
force-pushed
the
fix/right-panel-chat-surface
branch
from
9c5cdcd to
c6fdf38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the modal dark surface for the docked chat panel, remove its side inset and right padding, square its top-left corner, fix the docked panel icon button, and restore the floating panel toolbar and resize affordance polish.
Note
Low Risk
Mostly UI, layout, and tab/chat-mode behavior with broad unit test coverage; no auth, data, or security-sensitive paths.
Overview
Aligns floating and docked chat on the same dark stone modal chrome: the right panel shell,
ChatView, toolbar, empty state, and assistant bubbles all treatRightPanelOpenlike the floating dark surface instead of a light docked layout.Docked panel layout drops side insets and light borders in favor of flush
border-x/rounded-tr-xlstyling, with balancedpx-3padding on body, context bar, input, and toolbar in right-panel mode.Floating panel is anchored bottom-center (not bottom-right), with bottom corner resize handles and corner indicators removed; resize behavior tests were updated accordingly.
Toolbar uses pill title and circular ghost actions with
aria-label(tooltips removed on dark actions).Tab navigation collapses open chat to
FloatingClosedwhen navigating to Settings, not only when switching session tabs.Reviewed by Cursor Bugbot for commit c6fdf38. Bugbot is set up for automated code reviews on this repo. Configure here.