Flatten landing audio meter when typing stops#5581
Merged
Conversation
Drive the landing-page visualizer from the typewriter phase so it renders flat while the note animation is idle.
✅ Deploy Preview for old-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drive the landing-page visualizer from the typewriter phase so it renders flat while the note animation is idle.
Note
Low Risk
Landing-page animation and lifecycle cleanup only; no auth, data, or API changes.
Overview
The How it works demo ties the mock window’s
DancingSticksmeter to the typewriter:amplitudeis 1 only while characters are typing and 0 during pauses, enhancement reveals, and loop resets (desktop and mobile mockups).The typewriter loop is moved to
useMountEffectwith tracked timeouts/intervals and a cleanup that clears them on unmount, instead of leaving timers running after navigation away.Reviewed by Cursor Bugbot for commit 9ac5b2b. Bugbot is set up for automated code reviews on this repo. Configure here.