Keep collapsed session header height#5634
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
Keep the session outer header at h-12 when the left sidebar is collapsed and update the regression expectation.
ComputelessComputer
force-pushed
the
fix/session-header-height
branch
from
8127f77 to
3633f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the session outer header at h-12 when the left sidebar is collapsed and update the regression expectation.
Note
Low Risk
Small Tailwind class change and a matching test update in session header UI only; no auth, data, or API impact.
Overview
Unifies session outer header height so the bar is always
h-12(48px), whether the left sidebar is expanded or collapsed. Previously, the collapsed-sidebar gutter path usedh-11, which made the header shorter in that layout.The regression test for the collapsed-sidebar title layout now expects
h-12on the header instead ofh-11, aligned with the existing “keeps the session header at 48px tall” case.Reviewed by Cursor Bugbot for commit 3633f62. Bugbot is set up for automated code reviews on this repo. Configure here.