Remove delete recording overflow action#5637
Merged
Merged
Conversation
Summary: Removes the Delete recording item from the session overflow menu and updates overflow menu test coverage.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Removes the Delete recording item from the session overflow menu and updates overflow menu test coverage.
Note
Low Risk
UI-only menu change; delete recording may still be reachable elsewhere (e.g. audio timeline context menu).
Overview
Removes the Delete recording entry from the session header overflow menu (
OverflowButton), including theaudioExistsgating anduseAudioPlayerdependency that only existed to show it.Delete note and the rest of the overflow actions are unchanged. Tests drop the unused mocks and add coverage that Delete recording is absent while Delete note still renders.
Reviewed by Cursor Bugbot for commit 2e9dc64. Bugbot is set up for automated code reviews on this repo. Configure here.