Hide sidebar top fade at scroll boundary#5643
Merged
Merged
Conversation
Render the timeline top fade only after the sidebar has scrolled down and cover the boundary in timeline tests.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render the timeline top fade only after the sidebar has scrolled down and cover the boundary in timeline tests.
Note
Low Risk
Small conditional UI change in sidebar timeline chrome with updated unit tests; no data, auth, or API impact.
Overview
The sidebar timeline top chrome gradient overlay (
data-sidebar-timeline-top-fade) no longer renders when the list is at the top of the scroll area. It now appears only whentopChromeInsetis enabled and the user has scrolled down (!isScrolledToTop), matching the existing scroll-mask behavior for hidden future content.Tests assert the fade is absent before scrolling, then simulate scroll and verify the fade still uses the expected compact
h-16styling when the “Go back to now” chip path is active.Reviewed by Cursor Bugbot for commit b2583e7. Bugbot is set up for automated code reviews on this repo. Configure here.