Remove note preview hover cards#5646
Open
ComputelessComputer wants to merge 6 commits into
Open
Conversation
ComputelessComputer
force-pushed
the
fix/sidebar-note-window
branch
2 times, most recently
from
7314dc7 to
f989422
Compare
ComputelessComputer
changed the base branch from
fix/sidebar-note-window
to
main
ComputelessComputer
force-pushed
the
fix/remove-session-preview
branch
from
61ee511 to
772a2d0
Compare
✅ Deploy Preview for old-char canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Adds a note-specific native window route and wires sidebar double-click to open the existing note view in that window. Includes regression coverage for the sidebar double-click path.
Remove the sidebar session preview wrapper and delete its unused component and test.
Adds a note-specific native window route and wires sidebar double-click to open the existing note view in that window. Includes regression coverage for the sidebar double-click path.
Remove the sidebar session preview wrapper and delete its unused component and test.
ComputelessComputer
force-pushed
the
fix/remove-session-preview
branch
from
772a2d0 to
e7ab41c
Compare
Make InteractiveButton cleanup explicit and skip collapsed sidebar gutter in standalone note headers.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bd91c15. Configure here.
| clickTimeoutRef.current = setTimeout(() => { | ||
| clickTimeoutRef.current = null; | ||
| onClick?.(); | ||
| }, DOUBLE_CLICK_DELAY_MS); |
There was a problem hiding this comment.
Slow double-click opens tab
Medium Severity
When onDoubleClick is set, a single-click onClick runs after a fixed 350ms delay. If the second click of a double-click arrives after that delay (common with slower double-click timing or accessibility settings), the delayed openCurrent still runs and then the double-click opens the standalone note window, so both actions occur.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit bd91c15. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the sidebar session preview wrapper and delete its unused component and test.
This is part 2 of 2 in a stack made with GitButler:
Note
Medium Risk
Touches Tauri window lifecycle, STT stop controls in secondary windows, and changes primary sidebar open gestures; preview removal is low risk but window + live-session paths need manual QA.
Overview
Adds standalone note windows for sessions and removes sidebar hover preview cards for timeline rows.
Sessions can open in a dedicated Tauri window via
windowShow({ type: "note", value: sessionId }), backed by a new/app/note/$sessionIdroute that rendersTabContentNoteinStandaloneWindowShell. The windows plugin gains anAppWindow::Notevariant (labelnote-{id}, default size ~720×820).Sidebar timeline: session rows no longer use
SessionPreviewCard(component and tests deleted). Double-click or context Open in New Window opens the standalone window; Open in New Tab is removed for sessions. Single-click still opens the note in the main app after a short delay.InteractiveButtongains optionalonDoubleClickwith a 350ms single-click deferral and cleanup on unmount so double-clicks do not fire the single-click handler.OuterHeaderacceptsstandaloneWindowto show the stop-listening control and adjusted title insets without the collapsed-sidebar gutter.Reviewed by Cursor Bugbot for commit bd91c15. Bugbot is set up for automated code reviews on this repo. Configure here.