feat: enable remote profile, gateway, skills, and toolset management - #861
Open
itsJai42 wants to merge 9 commits into
Open
feat: enable remote profile, gateway, skills, and toolset management#861itsJai42 wants to merge 9 commits into
itsJai42 wants to merge 9 commits into
Conversation
…les-gateway-tools
…es-gateway-tools # Conflicts: # docs/superpowers/plans/2026-07-14-remote-management-parity.md # src/preload/index.d.ts # src/preload/index.ts # src/renderer/src/screens/Layout/Layout.tsx
Contributor
Greptile SummaryThis PR enables authenticated remote management across the desktop app. The main changes are:
Confidence Score: 4/5Remote profile mutation results need fixes before merging.
src/main/remote-profiles.ts Important Files Changed
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+89
to
+96
| await remoteDashboardRequestJson( | ||
| connection, | ||
| `/api/profiles/${encodeURIComponent(name)}`, | ||
| { | ||
| method: "DELETE", | ||
| }, | ||
| ); | ||
| return { success: true }; |
Contributor
There was a problem hiding this comment.
When the dashboard returns HTTP 200 with { ok: false }, this path ignores the response and reports { success: true }. The profile remains on the server while the UI treats it as deleted, so it reappears on refresh.
Suggested change
| await remoteDashboardRequestJson( | |
| connection, | |
| `/api/profiles/${encodeURIComponent(name)}`, | |
| { | |
| method: "DELETE", | |
| }, | |
| ); | |
| return { success: true }; | |
| const result = await remoteDashboardRequestJson<{ ok?: boolean }>( | |
| connection, | |
| `/api/profiles/${encodeURIComponent(name)}`, | |
| { | |
| method: "DELETE", | |
| }, | |
| ); | |
| return result?.ok === false | |
| ? { success: false, error: "Remote profile deletion failed." } | |
| : { success: true }; |
Comment on lines
+146
to
+147
| await remoteWriteSoul(connection, DEFAULT_SOUL, profile); | ||
| return DEFAULT_SOUL; |
Contributor
There was a problem hiding this comment.
When remoteWriteSoul() receives { ok: false }, it resolves to false, but this function still returns the default Soul. The editor can show a successful reset even though the remote profile kept its previous content.
Suggested change
| await remoteWriteSoul(connection, DEFAULT_SOUL, profile); | |
| return DEFAULT_SOUL; | |
| const written = await remoteWriteSoul(connection, DEFAULT_SOUL, profile); | |
| if (!written) throw new Error("Remote Soul reset was rejected."); | |
| return DEFAULT_SOUL; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remote-profiles.ts), rejecting local fallbacksremote-gateway.ts)remote-skills.ts,remote-toolsets.ts)remote-metadata.ts,messaging-platforms.ts)RemoteNoticelat.md/remote-management.mdBuilds on the remote management client from #855. Preserves the readiness boundary: non-remote connections are rejected at the request boundary and probe failures never guess or fall back to local state.
Verification
remote-profiles,remote-gateway,remote-skills,remote-toolsets,remote-metadata-auth,messaging-platforms.remote,remote-management-gates) — 25 passednpm test— 170 files passed; 1,772 tests passed; 3 skippednpm run typecheck— passed (node + web)lat check— passedgit diff --check upstream/main...HEAD— passedNo live remote-dashboard end-to-end session was performed; verification is automated source behavior and repository validation.