fix(ui): align appearance settings across locales - #880
Open
eachann1024 wants to merge 1 commit into
Open
Conversation
eachann1024
marked this pull request as ready for review
July 29, 2026 07:47
Contributor
Greptile SummaryUpdates the Appearance settings layout for translated and RTL content.
Confidence Score: 5/5The pull request appears safe to merge with no actionable defects identified. The markup and stylesheet changes consistently establish a shared responsive grid, supported wrapping behavior, logical RTL spacing, and a reachable narrow-container fallback without altering preference state or event handling.
|
| Filename | Overview |
|---|---|
| src/renderer/src/assets/main.css | Introduces the shared grid, wrapping controls, logical properties, and narrow-container fallback without an identified defect. |
| src/renderer/src/components/settings/AppearancePane.tsx | Adds consistent control wrappers to each preference row while preserving existing interaction behavior. |
| src/renderer/src/components/settings/AppearancePane.test.tsx | Adds focused markup and real-stylesheet contract coverage for translated, RTL, and narrow layouts. |
| lat.md/sidebar-navigation.md | Documents the new Appearance layout contract and its translation and RTL requirements. |
Reviews (1): Last reviewed commit: "fix: align settings preferences across l..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lat.md.Why
Translated settings copy varies substantially in length. The previous rows laid themselves out independently, so control positions and row alignment could drift between languages, while longer text could compete with non-shrinking segmented controls.
Root cause
Each row used its own flex layout and the segmented controls opted out of shrinking. There was no shared control column, no narrow-container fallback, and physical spacing did not fully express the intended logical direction behavior.
User impact
Appearance settings now keep a consistent text/control column in English, CJK, expanded translations, Arabic, and Hebrew. Long content wraps cleanly, RTL layouts mirror logically, and narrow panes stack controls without horizontal overflow.
Validation
npm run typecheck: passed.npm run lint: 0 errors; 21 baseline warnings remain in unrelated files.npx -y lat.md check: passed.The automated tests validate the rendered DOM structure together with declarations loaded from the real stylesheet. They do not launch the complete Electron application or assert browser pixel geometry.