debug: improve some logging bits #3713
Merged
+57
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
force-pushed
the
debug/improvement
branch
from
ae7bed2 to
b1da2b4
Compare
Refactor logging to support logging all messages, even those that precede availability for the __GODEBUG_OUTPUT__ window. Use functions instead of normal mode commands to manage the log window.
Start tracking the id on requests start at 1 instead of 2 by initializing the value to 0; it's incremented before set on outgoing requests.
bhcleek
force-pushed
the
debug/improvement
branch
from
b1da2b4 to
98c7803
Compare
Do not attempt to delete a command based on the first line of output from ":command GoDebug" trying to stop debugging. The error was causing the function to be aborted, which was in turn causing Neovim to hang when trying to quit. Similarly, swallow exceptions when removing commands and mappings.
bhcleek
force-pushed
the
debug/improvement
branch
from
49f1afb to
d2ed711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug: refactor logging
Refactor logging to support logging all messages, even those that
precede availability for the GODEBUG_OUTPUT window.
Use functions instead of normal mode commands to manage the log window.
debug: fix off by one error in request ids
Start tracking the id on requests start at 1 instead of 2 by
initializing the value to 0; it's incremented before set on outgoing
requests.
debug: avoid cleanup errors
Do not attempt to delete a command based on the first line of output
from ":command GoDebug" trying to stop debugging. The error was causing
the function to be aborted, which was in turn causing Neovim to hang
when trying to quit.
Similarly, swallow exceptions when removing commands and mappings.
debug: do not reschedule log timer when stopping