Add HIC_Unified binding model #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #230
When slicing the solution, make sure to include the start/endpoint s.t. later slicing at the same points does not lead to a ValueError.
ronald-jaepel
force-pushed
the
feature/add_unified_hic_binding
branch
from
556c28b to
5b4935c
Compare
|
The fixup is just to adapt to new SizedFloatList after a rebase to dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation for the eventual release of the HIC Paper by Eric, Johannes (Buyel) and me. Once that is published, we can merge the HIC branch in CADET-Core and add support for the HIC model in CADET-Process.
Pending: cadet/CADET-Core#433