-
Notifications
You must be signed in to change notification settings - Fork 18
Automate CLI releases. #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
doom-weaver
wants to merge
6
commits into
main
Choose a base branch
from
main_automateRelease
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
19a7bf7
Automate CLI releases.
018c92f
Format changes
2962556
iterate on release (not yet tested)
echo-bravo-yahoo 5443f86
add changesets for features in next release
echo-bravo-yahoo e887d3b
clean up dependencies
echo-bravo-yahoo 3dec38c
Apply suggestions from code review
echo-bravo-yahoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Changesets | ||
|
|
||
| Hello and welcome! This folder has been automatically generated by `@changesets/cli`, a build tool that works | ||
| with multi-package repos, or single-package repos to help you version and publish your code. You can | ||
| find the full documentation for it [in our repository](https://github.com/changesets/changesets) | ||
|
|
||
| We have a quick list of common questions to get you started engaging with this project in | ||
| [our documentation](https://github.com/changesets/changesets/blob/main/docs/common-questions.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/@changesets/config@3.0.5/schema.json", | ||
| "changelog": "@changesets/cli/changelog", | ||
| "commit": false, | ||
| "fixed": [], | ||
| "linked": [], | ||
| "access": "restricted", | ||
| "baseBranch": "main", | ||
| "updateInternalDependencies": "patch", | ||
| "ignore": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "fauna-shell": patch | ||
| --- | ||
|
|
||
| Redact secrets in verbose logging. | ||
|
|
||
| Logging the resolved CLI config could log out credentials if you had stored credentials in your config file. The CLI already redacts secrets that are logged by the verbose logger while parsing arguments/flags/environment variables, but this change additionally redacts secrets that would otherwise be logged by the verbose logger while parsing config files. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "fauna-shell": patch | ||
| --- | ||
|
|
||
| Fix incorrect nodeJS minimum version | ||
echo-bravo-yahoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| The documentation and package.json's "engine" field asserted that the CLI could be run with versions of nodeJS >= 20.x.x, but it makes use of APIs (specifically, the single-executable application API) that aren't available until nodeJS >= 20.18.x. This change updates the docs, "engines" field in the package.json file, and changes our test runner to test at 20.18 instead of the latest 20.x to prevent additions of further backwards-incompatible changes. | ||
echo-bravo-yahoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| "fauna-shell": patch | ||
| --- | ||
|
|
||
| Remove `--json` flag on commands that don't support it. | ||
echo-bravo-yahoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| The `--json` flag was presented as an option at the top level (modifying all commands), but only has an effect for a subset of commands. After this change, only the following commands have a `--json` field: | ||
echo-bravo-yahoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| - database create | ||
| - database list | ||
| - export get | ||
| - export create | ||
| - export list | ||
| - query | ||
| - shell | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "fauna-shell": patch | ||
| --- | ||
|
|
||
| Improve export user experience. | ||
echo-bravo-yahoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| - Export create now allows users to provide S3 URIs as a target to export to (with the flag `--desination`) in addition to providing each part independently (`--bucket`, `--path`) | ||
jrodewig marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
echo-bravo-yahoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Export create now supports user-provided idempotency tokens. Customers can use this to retry failed requests without triggering additional export workflows. | ||
echo-bravo-yahoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "fauna-shell": patch | ||
| --- | ||
|
|
||
| Support user-provided query retry and back-off settings for query and shell commands. For queries using FQLv10, `--max-attempts`, `--max-backoff`, `--timeout`, and `--max-contention-retries` are supported. For queries using FQLv4, `--timeout` and `--max-contention-retries` are supported. | ||
echo-bravo-yahoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| name: NPM Release | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "package.json" | ||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| # we need two commits | ||
| fetch-depth: 2 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "lts/*" | ||
| registry-url: "https://registry.npmjs.org" | ||
|
|
||
| - name: Check version | ||
| id: check_version | ||
| run: ./scripts/check-version.js | ||
|
|
||
| # - name: Generate Release Notes | ||
| # if: steps.check_version.outputs.do_publish == 'true' | ||
| # run: | | ||
| # if [ -f "RELEASE_NOTES.md" ] && grep -q "## \[${{ steps.check_version.outputs.new_version }}\]" RELEASE_NOTES.md; then | ||
| # sed -n "/## \[${{ steps.check_version.outputs.new_version }}\]/,/## \[/p" RELEASE_NOTES.md | sed '$d' > release_body.md | ||
| # else | ||
| # echo "### Automated Release Notes" > release_body.md | ||
| # echo "" >> release_body.md | ||
| # echo "#### Changes" >> release_body.md | ||
| # git log $(git describe --tags --abbrev=0)..HEAD --pretty=format:"- %s" >> release_body.md | ||
| # fi | ||
|
|
||
| - name: Create Git Tag | ||
| if: steps.check_version.outputs.do_publish == 'true' | ||
| run: | | ||
| git config user.name github-actions | ||
| git config user.email github-actions@github.com | ||
| git tag v${{ steps.check_version.outputs.new_version }} | ||
| git push origin v${{ steps.check_version.outputs.new_version }} | ||
|
|
||
| - name: Publish to NPM | ||
| if: steps.check_version.outputs.do_publish == 'true' | ||
| run: npm publish --dry-run | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
|
|
||
| - name: Create GitHub Release | ||
| if: steps.check_version.outputs.do_publish == 'true' | ||
| uses: actions/create-release@v1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| tag_name: v${{ steps.check_version.outputs.new_version }} | ||
| release_name: Release ${{ steps.check_version.outputs.new_version }} | ||
| body_path: release_body.md |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.