Fix telemetry hook crash on string toolUseResult - #174
Merged
Conversation
The UserPromptSubmit hook chained .get on entry["toolUseResult"], which is a string for rejected/errored tools. Type-guard with isinstance(..., dict) fixes 40 of 138 real transcripts that previously crashed and recovers reject telemetry on 37 of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
claude-telemetry-hooksUserPromptSubmit hook chained.getonentry["toolUseResult"], which Claude Code stores as a plain string (e.g."User rejected tool use","Error: EPERM ...") for rejected/errored tools. A type-guard withisinstance(..., dict)fixes 40 of 138 real transcripts that previously crashed and recovers reject telemetry on 37 of them. Bumps the plugin to 1.0.1.Before:
entry.get("toolUseResult", {}).get("interrupted")→AttributeError: 'str' object has no attribute 'get'After:
tur = tur if isinstance(tur, dict) else {}thentur.get("interrupted")