prompt restart when using fonts not available on start#356
Merged
eagleoflqj merged 4 commits intomasterfrom Apr 3, 2026
Merged
prompt restart when using fonts not available on start#356eagleoflqj merged 4 commits intomasterfrom
eagleoflqj merged 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds detection of user-installed fonts that appear after startup (which WKWebView can’t pick up without restart) and surfaces a restart prompt in the config UI when such fonts are selected.
Changes:
- Record user font families at process start and detect newly added font families when selecting a font.
- Show a restart prompt/action in the config UI when a newly added user font is chosen.
- Update/introduce zh-Hans/zh-Hant
Localizable.stringsentries and reuse a shareduserFontDirconstant.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server.swift | Captures user font families at launch for later “new font” detection. |
| src/config/font.swift | Adds user font directory constant + font-family enumeration utilities. |
| src/config/FontView.swift | Flags when a selected font comes from newly added user fonts. |
| src/config/SplitConfig.swift | Displays restart prompt/button when new fonts are detected. |
| src/config/ExternalView.swift | Uses shared userFontDir constant when opening Fonts folder. |
| assets/zh-Hant.lproj/Localizable.strings | Adds/updates Traditional Chinese localization strings. |
| assets/zh-Hans.lproj/Localizable.strings | Adds/updates Simplified Chinese localization strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #352