Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change adds overlay-message state to ChangesInput panel overlay messages
Startup logging
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant InputState
participant InputPanel
participant UIClients
InputState->>InputPanel: setOverlayMessage(input-method text)
InputState->>UIClients: update UI
InputPanel->>UIClients: provide overlay when panel is empty
UIClients->>UIClients: render auxiliary overlay text
InputState->>InputPanel: clear matching overlay message
InputState->>UIClients: update UI
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/frontend/dbusfrontend/dbusfrontend.cpp`:
- Around line 229-240: Route overlay messages through Instance::outputFilter
before assigning auxUp in dbusfrontend.cpp, inputwindow.cpp, and kimpanel.cpp at
the specified ranges, using each site’s existing input context or frontend
context argument. Preserve the current overlay handling while ensuring all three
renderers apply output filtering.
In `@src/lib/fcitx/inputpanel.h`:
- Around line 77-98: Update the documentation for InputPanel::overlayMessage()
to state that the overlay message is displayed only when the regular input panel
is empty, so normal panel content takes precedence. Remove or revise the wording
claiming that setting it suppresses all other fields, while preserving the
existing temporary-message and reset behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4af5d7ce-fcfc-4f82-9134-df654f41fccb
📒 Files selected for processing (7)
src/frontend/dbusfrontend/dbusfrontend.cppsrc/lib/fcitx/inputpanel.cppsrc/lib/fcitx/inputpanel.hsrc/lib/fcitx/instance.cppsrc/server/main.cppsrc/ui/classic/inputwindow.cppsrc/ui/kimpanel/kimpanel.cpp
Summary by CodeRabbit
New Features
Bug Fixes