fix(owner-onboarding-server): Re-run TO0 before it expires #207
Conversation
| @@ -244,6 +305,7 @@ async fn perform_maintenance(udt: OwnerServiceUDT) -> std::result::Result<(), &' | |||
|
|
|||
| #[allow(unused_must_use)] | |||
| let (ov_res, ses_res, rtr_res) = tokio::join!(ov_maint, ses_maint, rtr_maint); | |||
| let win_res = check_registration_window(udt.clone()).await; | |||
There was a problem hiding this comment.
Having this here would mean that this only gets executed after the maintenance or serving job has stopped. This code should probably be executed in the perform_maintenance method, and have that take the window into account.
There was a problem hiding this comment.
I don't know what you mean by 'after the job has stopped'. The check_registration_window is called inside the perform_maintenance method, as you ask. It simply waits until possible OV registration plus session maintenance has been made.
The window is taken into account inside the check_registration_window when we query fdo_store.
There was a problem hiding this comment.
I'm sorry, this was me mis-remembering how many join! calls there were in the code: I thought the only one was in the fn main().
| @@ -141,10 +157,58 @@ async fn report_to_rendezvous(udt: OwnerServiceUDT) -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| async fn check_registration_window(udt: OwnerServiceUDT) -> Result<()> { | |||
There was a problem hiding this comment.
We've discussed that this got pulled out separately because the query mechanism doesn't quite do what we'd want.
I'm going to look at improving and/or documenting that, and then get back to this shortly.
7flying
changed the title
Fixes #193
registration_time+re_registration_windoware now configured on the .yml.owner-onboarding-server.ymlhas been updated with these new parameters.registration_time+re_registration_window.