fix(dask): Preserve remote URIs (e.g. s3://) in DaskOfflineStore path #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkathole
reviewed
Apr 2, 2025
ntkathole
reviewed
Apr 3, 2025
|
Please sign the commit so that DCO commit pass |
predictorsSH
force-pushed
the
fix/dask-offline-store-s3-path
branch
from
e66f15e to
9356173
Compare
… resolution Signed-off-by: sanghyun <[email protected]> Signed-off-by: Sanghyun Kim <[email protected]>
refactor: use FileSource.get_uri_for_file_path for remote URI resolution Signed-off-by: Sanghyun Kim <[email protected]>
Signed-off-by: Sanghyun Kim <[email protected]>
predictorsSH
force-pushed
the
fix/dask-offline-store-s3-path
branch
from
9356173 to
806d0c4
Compare
|
@predictorsSH There is 1 more instance in the same file where absolute path is not correctly set up https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/dask.py#L472 |
… remote URIs Signed-off-by: sanghyun <[email protected]>
|
Thanks! I've applied the same fix to |
franciscojavierarceo
changed the title
|
@predictorsSH can you run the linter? |
Signed-off-by: sanghyun <[email protected]>
|
I've applied the formatting using make format-python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… resolution
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc