fix(feathers): Paginated<Result> for ServiceMethods.find#3223
Open
fratzinger wants to merge 3 commits intodovefrom
Open
fix(feathers): Paginated<Result> for ServiceMethods.find#3223fratzinger wants to merge 3 commits intodovefrom
fratzinger wants to merge 3 commits intodovefrom
Conversation
Member
Author
|
@daffl: I'm stuck with the error. The service It has to follow the common service definition, which should be How to continue?
|
Member
|
I'm not sure if we can add the pagination options to the main interface - I believe that's the error that is happening since any service interface implementor now expects the pagination overloads to be implement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The ReturnType of
ServiceMethods['find']wasPromise<Result | Result[]>. The correct way isPromise<Paginated<Result> | Result[]>.I also added it to
ServiceOverloads.