Skip to content

fix: resolve date display showing '1 day ago' for all reviews (#14) #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Karroch-a wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −5
Open

fix: resolve date display showing '1 day ago' for all reviews (#14) #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/apiTransformers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function transformV2ReviewToV1(reviewV2: GoogleReviewV2): GoogleReview {
starRating: reviewV2.rating ? reviewV2.rating.value : 0,
comment: reviewV2.text,
createTime: reviewV2.createdAt,
updateTime: reviewV2.updatedAt ?? null,
updateTime: reviewV2.publishedAt ?? null,
};
}

Expand Down
12 changes: 8 additions & 4 deletions src/utils/getRelativeDate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
export const getRelativeDate = (date: Date): string => {
const today = new Date();
const diffTime = Math.abs(today.getTime() - date.getTime());
const diffDays = Math.ceil(diffTime / (1000 * 60 * 60 * 24));
const diffDays = Math.floor(diffTime / (1000 * 60 * 60 * 24));
const diffMonths = Math.floor(diffDays / 30);
const diffYears = Math.floor(diffMonths / 12);

if (diffYears > 0) {
return `${diffYears} year${diffYears > 1 ? "s" : ""} ago`;
return `${diffYears} year${diffYears > 1 ? 's' : ''} ago`;
} else if (diffMonths > 0) {
return `${diffMonths} month${diffMonths > 1 ? "s" : ""} ago`;
return `${diffMonths} month${diffMonths > 1 ? 's' : ''} ago`;
} else if (diffDays === 0) {
return 'today';
} else if (diffDays === 1) {
return '1 day ago';
} else {
return `${diffDays} day${diffDays > 1 ? "s" : ""} ago`;
return `${diffDays} days ago`;
}
};