Skip to content

Finalize sampling callback #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simba-git merged 1 commit into from
Jul 14, 2025
Merged

Finalize sampling callback #139

simba-git merged 1 commit into from
Jul 14, 2025

Conversation

@simba-git
Copy link
Contributor

@simba-git simba-git commented Jul 14, 2025

Summary

  • improve openai_chat_agent example
    • add real sampling callback using ChatGPT or Ollama
    • add version check to only register callback when mcp_use supports it
  • clean up travel planner example

Testing

  • make setup
  • make test

https://chatgpt.com/codex/tasks/task_e_687482a36520832a8b9e3cb0acb647d4

@simba-git simba-git merged commit 389b78d into feat/sampling-example/simba Jul 14, 2025
3 checks passed
@simba-git simba-git deleted the codex/update-sampling-callback-to-use-llm branch July 14, 2025 07:11
simba-git added a commit that referenced this pull request Jul 14, 2025
@simba-git
Add sampling support example and add ask_user (#138)
1779e04 
* Add sampling support to chatbot example

* Use LLM in sampling callback with version check (#139)

* Use info logging in chatbot (#142)

* Add ask_user support (#143)

* Upgrade MCP and add ask_user

* Fix example lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simba-git