feat: create structs representing Featurevisor instance and config manager #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahad19
reviewed
Nov 1, 2023
| package config | ||
|
|
||
| // Config represents a parsed datafile config. | ||
| type Config interface { |
There was a problem hiding this comment.
idea is to keep the interfaces/API as similar as the original JS SDK: https://github.com/featurevisor/featurevisor/tree/main/packages/sdk/src
this is how we are approaching Swift and Kotlin SDKs as well, helping keep it relatively easy to port bug fixes everywhere continuously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress branch for
InstanceandConfigstructs implementations, together with suggested public API for instantiating new Featuvisor client.The Featurevisor instance is created with
Configstruct that responsible for reading the remote datafile config and holding methods for accessing underlying JSON field.