Skip to content

Update fedberry repo to make it compatible with fedora repo #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwrobel
Copy link
Member

@dwrobel dwrobel commented Jul 15, 2019

  • Remove fedora repositories and add it as Requires
  • Increase priority of fedberry repositories
  • Install with preserving original timestamps

 - Remove fedora repositories and add it as Requires
 - Increase priority of fedberry repositories
 - Install with preserving original timestamps
@dwrobel
Copy link
Member Author

dwrobel commented Jul 15, 2019

Basically this allows to remove the conflict between fedberry and fedora packages. It relies on the DNF priority configuration option.

Taking advantage of that I'm able to create an image of fedora-arm-server.ks with minimal changes (can be seen here: https://pagure.io/fork/dwrobel/fedora-kickstarts/commits/fedora-arm-server-rpi4).

In practise in fedora-server product the list of packages from fedberry repository would be very minimal:

# dnf repository-packages smock-dw list --installed
Installed Packages
bcm283x-firmware.armv7hl                                                                               20190703-1.383fcf5.fc30                                                                            @smock-dw
bcm434xx-firmware.noarch                                                                               20190420-1.b518de4.fc30                                                                            @smock-dw
kernel.armv7hl                                                                                         4.19.57-5.rpi.fc30                                                                                 @smock-dw
kernel-core.armv7hl                                                                                    4.19.57-5.rpi.fc30                                                                                 @smock-dw
kernel-modules.armv7hl                                                                                 4.19.57-5.rpi.fc30                                                                                 @smock-dw
kernel-tools.armv7hl                                                                                   4.19.57-5.rpi.fc30                                                                                 @smock-dw
kernel-tools-libs.armv7hl                                                                              4.19.57-5.rpi.fc30                                                                                 @smock-dw
raspberrypi-vc-libs.armv7hl                                                                            20181213-1.7cbfbd3.fc30                                                                            @smock-dw
raspberrypi-vc-utils.armv7hl                                                                           20181213-1.7cbfbd3.fc30                                                                            @smock-dw
smock-dw.noarch         

Please substitue smock-dw with fedberry (as this is my private repo I used to verify the image till fedberry will support fc30).

@agrez
Copy link
Member

agrez commented Jul 21, 2019

Hi Derick. Apologies for the lack of response on this pull request thus far. I just haven't had time to have a good look at it until now.

Thanks for the pull request, but presently, I am reluctant to pull it in for one main reason. I have experimented with using yum repo priorities in the past and I still ended up with some Fedora updates wiping out my exiting fedberry specific packages. It either doesn't function as advertised (ie its buggy) or else it can only prioritise packages in other repos to some degree. I have found that using excludes in the yum repos files is the only reliable way to ensure that fedberry packages won't get wiped out by a fedora update and leave the system in a broken state. To easily add/remove excludes in fedora yum repos files, you need control of them, therefore we need to package and carry them ourselves.

I suppose I could split them out of this package back into the originally named 'fedora-repos' rpm and carry this rpm (with the modified fedora repo files) in fedberry repos. Would this help solve the issues you are facing?

@dwrobel
Copy link
Member Author

dwrobel commented Jul 26, 2019

Hi Derick.

You meant Damian :-)

Apologies for the lack of response on this pull request thus far. I just haven't had time to have a good look at it until now.

No problem, everybody are busy.

Thanks for the pull request, but presently, I am reluctant to pull it in for one main reason. I have experimented with using yum repo priorities in the past and I still ended up with some Fedora updates wiping out my exiting fedberry specific packages. It either doesn't function as advertised (ie its buggy)

It's understandable. BTW did you report any issues against yum/dnf?

or else it can only prioritise packages in other repos to some degree. I have found that using excludes in the yum repos files is the only reliable way to ensure that fedberry packages won't get wiped out by

The problem with that approach is that you have to manually cherry-pick any changes from original Fedora repositories (e.g. now fedberry doesn't have anything related to modularity, etc...).

I suppose I could split them out of this package back into the originally named 'fedora-repos' rpm and carry this rpm (with the modified fedora repo files) in fedberry repos. Would this help solve the issues you are facing?

IMHO in a long term it would be better to make sure that priority option is working as advertised.
So, I will try to install more packages from my private repository (the one with increased priority=50), and check if packages gets updated from that repository instead from the standard ones (with priority=99).

@agrez
Copy link
Member

agrez commented Jul 27, 2019

Hi s'/Derick/Damien/' ;-)

At the time I didn't report anything against dnf but this was a fair while ago (I think I dragged the fedora repos in for the f27 release), so it would be definitely worth checking the behaviour again with f30.

I agree, my preference is for a priority option that works reliably and predictably so I don't have to worry about syncing with Fedora changes upstream. From memory, I also think I had issues with priorities when using appliance-creator to build release images, so I would want that working as well.

BTW, I started on f30 builds a few months ago, but have been snowed under with work ever since and haven't made much progress. Haven't pushed anything to repo servers as yet.

@dwrobel
Copy link
Member Author

dwrobel commented Jul 29, 2019

Hi s'/Derick/Damien/' ;-)

Third time lucky: s/Damien/Damian/ :-)

so it would be definitely worth checking the behaviour again with f30.

FYI, I found one issue and reported it here: https://bugzilla.redhat.com/show_bug.cgi?id=1733582

@agrez
Copy link
Member

agrez commented Jul 30, 2019

Third time lucky: s/Damien/Damian/ :-)

With my track record in this thread, it would seem I might need more! ;-)

@dwrobel
Copy link
Member Author

dwrobel commented Aug 16, 2019

Currently I have working priority support in both dnf and appliance-creator using the following versions/changes:

I'll try to work with upstream to have this functionality merged.

@agrez
Copy link
Member

agrez commented Aug 19, 2019

Nice work! Hopefully the libsolv changes will filter down sooner rather than later. I don't really mind carrying downstream builds of livecd-tools / pykickstart if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants