Create a new Delivery struct that includes Timestamp
#555
Conversation
**Note:** This is an API breaking change. Currently the `Timestamp` value is being dropped as part of the conversion from `BorrowedMessage` to `OwnedDeliveryResult`, however this value is updated once the message has been published and callers should have access to the updated value. As far as I can tell, this is the **only** other value that is updated as part of publishing. An alternative to expanding the tuple would be to replace it with a struct. This is a bit more disruptive now, but would making adding values in the future a backwards compatible change. So it depends how likely it is that there will be further new values. This could also be done in a way that isn't a breaking change, but would involve duplicating functions and copying some types, i.e. `DeliveryFuture`. It doesn't seem like that level of complexity is justified given the pre 1.0 status.
|
Any chance someone could take a look at this? I would like get our production systems off my fork if at all possible. |
|
@davidblewett When you get a moment, could you review this PR? We'd love to stop maintaining a fork for this small change. ❤️ |
|
Thanks, @davidblewett! Good to know. We'll get back to you soon with that change. |
Just to set expectations, we'll most likely deliver this change next month after the holidays. We want to make sure to give it a thorough review and testing on our end before submitting it upstream. Happy Holidays! 😄 |
I have switched this out. Let me know if there is anything else you would like me to change. |
gorzell
changed the title
Timestamp to the OwnedDeliveryResult tuple.Delivery struct that includes Timestamp
|
@davidblewett I hope you had some fantastic winter holidays! How is this PR looking to you? |
|
@davidblewett changelog updated. |
Note: This is an API breaking change.
Currently the
Timestampvalue is being dropped as part of the conversion fromBorrowedMessagetoOwnedDeliveryResult, however this value is updated once the message has been published and callers should have access to the updated value. As far as I can tell, this is the only other value that is updated as part of publishing.The new struct is returned as part of the
OwnedDeliveryResult.An alternative to expanding the tuple would be to replace it with a struct. This is a bit more disruptive now, but would make adding values in the future a backwards compatible change. So it depends how likely it is that there will be further new values.This could also be done in a way that isn't a breaking change, but would involve duplicating functions and copying some types, i.e.
DeliveryFuture. It doesn't seem like that level of complexity is justified given the pre 1.0 status.