fix: prevent direct construction of BorrowedHeaders#835
Open
Sieger9303 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #825.
Hi, thanks for maintaining this crate.
BorrowedHeadersrepresents a borrowed view over a nativerd_kafka_headers_tpointer. Its methods convert&BorrowedHeadersback into that native pointer before calling librdkafka.Because
BorrowedHeaderswas a public unit struct, downstream safe code could construct one directly. Such a value is not backed by a valid librdkafka headers pointer, so calling methods likedetach()could pass an invalid pointer to librdkafka and segfault.This PR adds a private field to
BorrowedHeaders, making it non-constructible outside the crate while keeping the normal construction paths through borrowed messages and owned headers unchanged.