Skip to content

feat: add reject/accept to Activity class #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmaseCocoa merged 3 commits into from
Apr 7, 2026
Merged

feat: add reject/accept to Activity class #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cf4d1d
feat: add accept/reject in activity class
AmaseCocoa Apr 7, 2026
7cf0d76
Update activitystreams
AmaseCocoa Apr 7, 2026
4273023
Merge branch 'develop' of https://github.com/AmaseCocoa/apmodel into …
AmaseCocoa Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions schemas/core.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ classes:
extends: Object
isCoreType: true
mixins:
- ActivityMixin
properties:
actor:
type: WrapAS2[Object] | str | None
Expand Down
18 changes: 18 additions & 0 deletions src/apmodel/mixins/activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
from typing import TYPE_CHECKING

if TYPE_CHECKING:
from apmodel.activity import Accept, Reject
from apmodel.core import Activity
from apmodel.objects import Actor


class ActivityMixin:
def accept(self: "Activity", id: str, actor: "Actor") -> "Accept":
from apmodel.activity.accept import Accept

return Accept(id=id, actor=actor, object=self)

def reject(self: "Activity", id: str, actor: "Actor") -> "Reject":
from apmodel.activity.reject import Reject

return Reject(id=id, actor=actor, object=self)
Comment on lines +1 to +18
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current implementation of accept and reject requires an id as a positional argument. In many ActivityPub scenarios, the ID of a new activity might not be known at creation time (e.g., it's assigned by the server later) or should be optional.

Additionally, the actor parameter is typed strictly as Actor, but in practice, it is often provided as a URI string.

I suggest:

  1. Making id optional with a default of None.
  2. Swapping the order of actor and id to allow id to be optional while keeping actor required.
  3. Allowing actor to be a str.
  4. Adding from __future__ import annotations to simplify type hints and avoid circular evaluation issues at runtime.
Suggested change
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from apmodel.activity import Accept, Reject
from apmodel.core import Activity
from apmodel.objects import Actor
class ActivityMixin:
def accept(self: "Activity", id: str, actor: "Actor") -> "Accept":
from apmodel.activity.accept import Accept
return Accept(id=id, actor=actor, object=self)
def reject(self: "Activity", id: str, actor: "Actor") -> "Reject":
from apmodel.activity.reject import Reject
return Reject(id=id, actor=actor, object=self)
from __future__ import annotations
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from apmodel.activity import Accept, Reject
from apmodel.core import Activity
from apmodel.objects import Actor
class ActivityMixin:
def accept(self: Activity, actor: Actor | str, id: str | None = None) -> Accept:
from apmodel.activity.accept import Accept
return Accept(id=id, actor=actor, object=self)
def reject(self: Activity, actor: Actor | str, id: str | None = None) -> Reject:
from apmodel.activity.reject import Reject
return Reject(id=id, actor=actor, object=self)

2 changes: 1 addition & 1 deletion vendor/activitystreams
Open in desktop
Submodule activitystreams updated 2 files
+3 −5 ERRATA.md
+10 −4 vocabulary/index.html
Loading