-
-
Notifications
You must be signed in to change notification settings - Fork 85
Remove deprecated @fedify/fedify/x/* modules
#467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring and modularization of the Fedify project, aiming to create a lighter core library and improve adherence to ActivityPub standards. It introduces new dedicated packages for vocabulary management and relay functionality, while removing deprecated internal modules. These changes streamline the project structure, enhance maintainability, and provide clearer separation of concerns, preparing the groundwork for future development and improved compatibility across various JavaScript runtimes and web frameworks. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the deprecated @fedify/fedify/x/* modules, which is a great cleanup effort. The changes are consistent across the codebase, including documentation, configuration, and example files. I've found a couple of minor points to address: a small wording improvement in the changelog and a missing development dependency in packages/fedify.
|
The docs for this pull request have been published: |
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
Summary
Remove deprecated
@fedify/fedify/x/*modules.Related Issue
@fedify/fedify/x/*modules in Fedify 2.0 #391Changes
examples/blogdocsexamplesBenefits
Without deprecated modules, now
@fedify/fedifymodule is lighter than before.Checklist
Did you write some relevant docs about this change (if it's a new feature)?Did you write a regression test to reproduce the bug (if it's a bug fix)?Did you write some tests for this change (if it's a new feature)?deno task test-allon your machine?Additional Notes
After this issue and #466, the
blogexample should be recreated.