Skip to content

Conversation

@dodok8
Copy link
Contributor

@dodok8 dodok8 commented Oct 16, 2025

Summary

Fix the bug notice message of init doesn't show properly, and change console.log in fedify nodeinfo --raw to print

Related Issue

Reference the related issue(s) by number, e.g.:

Changes

  • In packages/cli/src/init/action/notice.ts
    • Apply text() to show pre-formatted text
  • In packages/cli/src/nodeinfo.ts
    • Apply text() and print() in --raw option.

Benefits

Notice message after init is done is now shown properly and non-escaped.

Checklist

  • Did you add a changelog entry to the CHANGES.md?
  • Did you write some relevant docs about this change (if it's a new feature)?
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
  • Did you write some tests for this change (if it's a new feature)?
  • Did you run deno task test-all on your machine?

Additional Notes

Include any other information, context, or considerations.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses two display-related issues within the fedify CLI. It fixes a bug where the initialization notice message was not rendered correctly, ensuring that important post-initialization information is now properly formatted and visible to the user. Additionally, it refines the output for the nodeinfo --raw command by switching from console.log to print with text() to handle raw JSON output more consistently, improving the overall user experience and output reliability.

Highlights

  • Fixes Init Notice Message Display: The pull request resolves a bug where the notice message displayed after fedify init was not showing properly, ensuring that important post-initialization information is now correctly formatted and visible.
  • Refines NodeInfo Raw Output: The output for the fedify nodeinfo --raw command has been improved by switching from console.log to print with the text() utility, ensuring raw JSON output is handled more consistently.
  • Introduces text() Utility: The text() utility from @optique/core is now used in both the init notice and nodeinfo raw output to ensure pre-formatted text is displayed without unintended escaping.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@issues-auto-labeler issues-auto-labeler bot added component/cli CLI tools related component/nodeinfo NodeInfo related good first issue Good for newcomers labels Oct 16, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses a bug where the init notice message was not displaying correctly and modifies the fedify nodeinfo --raw command to use print instead of console.log. The changes involve using the text() function to properly format the notice message and switching to print for outputting raw NodeInfo data. There are a couple of suggestions for improvement related to error handling and code clarity.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

The latest push to this pull request has been published to JSR and npm as a pre-release:

Package Version JSR npm
@fedify/fedify 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/cli 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/amqp 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/cfworkers 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/denokv 2.0.0-pr.469.1873+ebbd8642 JSR
@fedify/elysia 2.0.0-pr.469.1873+ebbd8642 npm
@fedify/express 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/h3 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/hono 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/koa 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/nestjs 2.0.0-pr.469.1873+ebbd8642 npm
@fedify/next 2.0.0-pr.469.1873+ebbd8642 npm
@fedify/postgres 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/redis 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/sqlite 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/sveltekit 2.0.0-pr.469.1873+ebbd8642 JSR npm
@fedify/testing 2.0.0-pr.469.1873+ebbd8642 JSR npm

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

The docs for this pull request have been published:

https://010bfde5.fedify.pages.dev

@dahlia dahlia merged commit 76cf786 into fedify-dev:next Nov 1, 2025
10 of 19 checks passed
@dodok8 dodok8 deleted the fix/465 branch November 5, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/cli CLI tools related component/nodeinfo NodeInfo related good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants