-
-
Notifications
You must be signed in to change notification settings - Fork 85
fix: fedify init notice message deosn't show properly #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two display-related issues within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request addresses a bug where the init notice message was not displaying correctly and modifies the fedify nodeinfo --raw command to use print instead of console.log. The changes involve using the text() function to properly format the notice message and switching to print for outputting raw NodeInfo data. There are a couple of suggestions for improvement related to error handling and code clarity.
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
|
The docs for this pull request have been published: |
Summary
Fix the bug notice message of init doesn't show properly, and change
console.loginfedify nodeinfo --rawtoprintRelated Issue
Reference the related issue(s) by number, e.g.:
Changes
packages/cli/src/init/action/notice.tstext()to show pre-formatted textpackages/cli/src/nodeinfo.tstext()andprint()in--rawoption.Benefits
Notice message after init is done is now shown properly and non-escaped.
Checklist
deno task test-allon your machine?Additional Notes
Include any other information, context, or considerations.