frontend: fix packit_forge_projects_allowed to return list in API #4092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema incorrectly defined field as String instead of List(String), causing Flask-RESTX to stringify the list in API responses. Context: packit/packit-service#2907 (comment) Assisted-by: Cursor(Claude)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where the packit_forge_projects_allowed field was being stringified in API responses. The change updates the schema from String to List(String), which is the correct approach. The description and example in the schema have also been updated for consistency. Furthermore, a new test case has been added to verify that the API now returns a list as expected, ensuring the fix is effective and preventing future regressions. The changes are clear, focused, and well-implemented.
Pull Request validationFailed🔴 Failed or pending checks:
🔴 Review - Missing review from a member (2 required) |
3 tasks
evgeni
added a commit
to evgeni/packit-service
that referenced
this pull request
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema incorrectly defined field as String instead of List(String), causing Flask-RESTX to stringify the list in API responses. Context: packit/packit-service#2907 (comment)
Assisted-by: Cursor(Claude)