Skip to content

Getting topic from env var with a reasonable default#27

Merged
jpodivin merged 1 commit into
fedora-copr:mainfrom
jpodivin:topic
Mar 9, 2026
Merged

Getting topic from env var with a reasonable default#27
jpodivin merged 1 commit into
fedora-copr:mainfrom
jpodivin:topic

Conversation

@jpodivin

@jpodivin jpodivin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Now we can set the topic using environment variables. This is very useful for containerized deployment.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's configuration flexibility by allowing the message topic to be set via an environment variable. This change significantly improves adaptability for containerized deployments, enabling easier management and overriding of the topic without requiring code modifications, thereby streamlining deployment processes and enhancing maintainability.

Highlights

  • Environment Variable Configuration: The TOPIC variable, previously hardcoded, can now be configured using the LD_TOPIC environment variable. A new default value of "org.fedoraproject.prod.logdetective.analysis" is provided if the environment variable is not set.
Changelog
  • src/logdetective_packit/main.py
    • Updated the TOPIC variable to read its value from the LD_TOPIC environment variable, falling back to a new default if not present.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes the messaging topic configurable via the LD_TOPIC environment variable and sets a new, more specific default topic name. The implementation is straightforward and consistent with how other configuration variables are handled in the project. I have reviewed the changes and have no feedback.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
@jpodivin jpodivin merged commit 4ca154a into fedora-copr:main Mar 9, 2026
3 checks passed
@jpodivin jpodivin deleted the topic branch March 9, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants