Skip to content

Modifying config for production#28

Merged
jpodivin merged 1 commit into
fedora-copr:mainfrom
jpodivin:new_config
Mar 9, 2026
Merged

Modifying config for production#28
jpodivin merged 1 commit into
fedora-copr:mainfrom
jpodivin:new_config

Conversation

@jpodivin

@jpodivin jpodivin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Our configuration needs some changes before it can be put into production.
Several sections are unnecessary, because we are only producing messages, not consuming them.

This also fixes topic prefix and sets proper amqp url.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the server/conf.toml configuration to align with production requirements, specifically for a message-producing service. It streamlines the configuration by removing unnecessary consumer-specific settings and corrects the AMQP connection details and topic prefix to ensure proper integration within the production environment.

Highlights

  • AMQP Configuration Update: The amqp_url has been updated to use logdetective-packit credentials and the topic_prefix is now set to org.fedoraproject.prod for production messaging.
  • Passive Declares Enabled: The passive_declares setting has been changed from false to true.
  • Consumer-Related Sections Removed: All configuration sections related to message consumption, including queues, bindings, and consumer_config, have been removed as this instance is only producing messages.
Changelog
  • server/conf.toml
    • Updated amqp_url to use logdetective-packit and a different endpoint.
    • Changed passive_declares from false to true.
    • Set topic_prefix to org.fedoraproject.prod.
    • Removed the queues.197dc06b-3ae6-435a-93dc-baad4e39cda2 section.
    • Removed the bindings section.
    • Removed the consumer_config section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the configuration for production. It changes the AMQP URL, sets passive_declares to true, updates the topic_prefix, and removes unnecessary consumer-related sections. The changes align with the goal of setting up a producer-only service for production. However, I've identified a security concern with the hardcoded AMQP URL, which includes a username. I've suggested replacing the hardcoded value with a comment and using an environment variable instead, which is a more secure practice.

Note: Security Review has been skipped due to the limited scope of the PR.

Comment thread server/conf.toml
@jpodivin jpodivin merged commit 8bd2512 into fedora-copr:main Mar 9, 2026
3 checks passed
@jpodivin jpodivin deleted the new_config branch March 9, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants