Performance and other improvements#33
Merged
Merged
Conversation
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a global AsyncClient for HTTP requests and implements a lifespan manager to ensure background tasks are completed during application shutdown. It also refactors the handling of analysis start times to use datetime objects instead of strings and improves task error reporting via Sentry. A review comment suggests explicitly closing the http_client within the lifespan manager to ensure all resources are properly released.
Jany26
requested changes
Apr 8, 2026
Jany26
left a comment
Contributor
There was a problem hiding this comment.
I wonder if we should add some config file, as the number of env variables keeps increasing 😅
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Jany26
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon examination, it turned out that we are mostly right about the worker number. In fact, even 4 may be an overkill, since we are I/O bound. I have at least parametrized it, so we can adjust the value in production.
Further changes: