Move data structures to a subpackage to be used by packit#34
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request extracts the Fedora Messaging schema and result enum into a new standalone Python package named logdetective-packit-message located in the schema/ directory. The main service, Docker configuration, and tests have been updated to depend on this new package, ensuring consistency across different consumers. Additionally, several fields in the README were marked as optional to reflect the updated schema. I have no feedback to provide.
Reviewed-by: Claude Opus 4.6 Signed-off-by: Jan Matufka <jmatufka@redhat.com>
jpodivin
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We left this for a little (while fixing LD trigger in packit-service) but I wanted to revisit this issue and maybe clarify some stuff:
pip install "logdetective-packit-message @ git+https://github.com/fedora-copr/logdetective-packit.git#subdirectory=schema"? maybe something to discuss with other packit members...test_analyze_build_skeleton()which was defined twice and the first test got overshadowed, the second got renamed to*_no_token()