Skip to content

Power virtual server implementation#32

Merged
praiskup merged 4 commits into
fedora-copr:mainfrom
nikromen:powervs
Jul 21, 2025
Merged

Power virtual server implementation#32
praiskup merged 4 commits into
fedora-copr:mainfrom
nikromen:powervs

Conversation

@nikromen

@nikromen nikromen commented Jul 8, 2025

Copy link
Copy Markdown
Member

No description provided.

@nikromen

nikromen commented Jul 8, 2025

Copy link
Copy Markdown
Member Author

/packit build

Comment thread resalloc_ibm_cloud/ibm_cloud_vm.py Outdated
"list", help="List all PowerVS instances in IBM Cloud"
)

return parser

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is true, that this adds many more parameters compared to the original non-powerful builders.

But to me, it seems that they are not new or different. It's just that for normal builders, we have them in a config file. I don't know where the config is on Fedora Copr but in case of Internal Copr, it is the deployment repository and roles/copr/backend/templates/ibm-cloud-config.j2

Can we unify the configuration and use either parameters or a config file for both types of builders or is there some reason why we can't/shouldn't?

@nikromen nikromen Jul 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not about configuration or powerful builders. This is a Python CLI implementation for managing resources in Power Virtual Server, IBM Cloud - the power in the name is just a coincidence. The PowerVS cloud is basically a completely different cloud than VPC (so we can't use something from the VPC cloud config), even though both are under the IBM Cloud... It's like AWS and Azure but under the same website... I'll update the description of this PR/commits later once I have the functionality fully tested

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where the config is on Fedora Copr

we don't use power virtual server cloud in fedora copr

Comment thread resalloc_ibm_cloud/powervs/powervs_vm.py Outdated
@nikromen nikromen force-pushed the powervs branch 10 times, most recently from e06f8f5 to 8219903 Compare July 9, 2025 13:13
@nikromen nikromen force-pushed the powervs branch 9 times, most recently from 7b87d9e to c89adcd Compare July 9, 2025 18:14
@nikromen nikromen force-pushed the powervs branch 3 times, most recently from 4347efc to 0b69aa2 Compare July 10, 2025 11:06
@praiskup praiskup merged commit 1716415 into fedora-copr:main Jul 21, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants