ci: allow the installation of greenboot rpm packages from compose#178
Open
mcattamoredhat wants to merge 1 commit intofedora-iot:mainfrom
Open
ci: allow the installation of greenboot rpm packages from compose#178mcattamoredhat wants to merge 1 commit intofedora-iot:mainfrom
mcattamoredhat wants to merge 1 commit intofedora-iot:mainfrom
Conversation
knecasov
reviewed
Apr 27, 2026
| BOOT_ARGS="uefi" | ||
| BOOT_LOCATION="http://${DOWNLOAD_NODE}/rhel-9/nightly/RHEL-9/latest-RHEL-9.8.0/compose/BaseOS/x86_64/os/" | ||
| if [[ "${USE_COMPOSE_RPMS}" == true ]]; then | ||
| GREENBOOT_PACKAGES_URL="https://${DOWNLOAD_NODE}/rhel-9/composes/RHEL-9/${COMPOSE_ID}/compose/AppStream/x86_64/os/Packages/" |
There was a problem hiding this comment.
It seems that { set +x; } 2>/dev/null ... set -x is missing here.
Member
There was a problem hiding this comment.
yes, for sake of consistency with the other scripts we can have it here...
knecasov
reviewed
Apr 27, 2026
Comment on lines
+117
to
+135
| greenprint "Downloading greenboot RPMs from compose: ${GREENBOOT_PACKAGES_URL}" | ||
|
|
||
| GREENBOOT_RPM="$(curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \ | ||
| "${GREENBOOT_PACKAGES_URL}" \ | ||
| | grep -oE 'greenboot-[0-9][^"]*\.rpm' \ | ||
| | grep -vE 'debug(info|source)' \ | ||
| | sort -V | tail -n 1)" | ||
| echo "Selected greenboot RPM: ${GREENBOOT_RPM}" | ||
|
|
||
| GREENBOOT_DEFAULT_RPM="$(curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \ | ||
| "${GREENBOOT_PACKAGES_URL}" \ | ||
| | grep -oE 'greenboot-default-health-checks-[0-9][^"]*\.rpm' \ | ||
| | sort -V | tail -n 1)" | ||
| echo "Selected greenboot-default-health-checks RPM: ${GREENBOOT_DEFAULT_RPM}" | ||
|
|
||
| curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \ | ||
| "${GREENBOOT_PACKAGES_URL}${GREENBOOT_RPM}" -o "/var/www/html/packages/${GREENBOOT_RPM}" | ||
| curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \ | ||
| "${GREENBOOT_PACKAGES_URL}${GREENBOOT_DEFAULT_RPM}" -o "/var/www/html/packages/${GREENBOOT_DEFAULT_RPM}" |
There was a problem hiding this comment.
It seems that { set +x; } 2>/dev/null ... set -x is missing here.
knecasov
reviewed
Apr 27, 2026
| greenprint "Downloading greenboot RPMs from compose" | ||
| rm -f greenboot-*.rpm | ||
|
|
||
| GREENBOOT_RPM="$(curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \ |
There was a problem hiding this comment.
I would explain why the option -k is needed.
knecasov
reviewed
Apr 27, 2026
| greenprint "Downloading greenboot RPMs from compose" | ||
| rm -f greenboot-*.rpm | ||
|
|
||
| GREENBOOT_RPM="$(curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \ |
There was a problem hiding this comment.
I would explain why the option -k is needed.
knecasov
reviewed
Apr 27, 2026
| if [[ "${USE_COMPOSE_RPMS}" == true && -n "${GREENBOOT_PACKAGES_URL}" ]]; then | ||
| greenprint "Downloading greenboot RPMs from compose: ${GREENBOOT_PACKAGES_URL}" | ||
|
|
||
| GREENBOOT_RPM="$(curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \ |
There was a problem hiding this comment.
I would explain why the option -k is needed.
knecasov
reviewed
Apr 27, 2026
knecasov
left a comment
knecasov
left a comment
There was a problem hiding this comment.
I added a few comments.
Have you considered extracting the shared parts of the code (for example, an RPM download logic) into a common helper, please? The same block is repeated across all three scripts.
knecasov
reviewed
Apr 27, 2026
| greenprint "Downloading greenboot RPMs from compose" | ||
| rm -f greenboot-*.rpm | ||
|
|
||
| GREENBOOT_RPM="$(curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \ |
There was a problem hiding this comment.
The following command could be extracted into a variable to download the page once. It applies to all occurrences.
curl -kfsSL --retry 5 --retry-delay 2 --retry-all-errors \
"${GREENBOOT_PACKAGES_URL}"
say-paul
approved these changes
Apr 28, 2026
| BOOT_ARGS="uefi" | ||
| BOOT_LOCATION="http://${DOWNLOAD_NODE}/rhel-9/nightly/RHEL-9/latest-RHEL-9.8.0/compose/BaseOS/x86_64/os/" | ||
| if [[ "${USE_COMPOSE_RPMS}" == true ]]; then | ||
| GREENBOOT_PACKAGES_URL="https://${DOWNLOAD_NODE}/rhel-9/composes/RHEL-9/${COMPOSE_ID}/compose/AppStream/x86_64/os/Packages/" |
Member
There was a problem hiding this comment.
yes, for sake of consistency with the other scripts we can have it here...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggest the changes to allow the installation of the greenboot rpm packages from a given compose specified by a local variable COMPOSE_ID.
If that variable is defined, qcow2, anaconda-iso, and ostree ci test cases will fetch the rpms from the RHEL composes available through DOWNLOAD_NODE url. So that local testing efforts are simpler and more automated.