add fallback to greenboot#181
Open
say-paul wants to merge 4 commits intofedora-iot:mainfrom
Open
Conversation
Set fallback=1 alongside greenboot_rollback_trigger when an OS update is detected, enabling GRUB to boot the previous deployment if the new kernel panics. Disarm fallback at the start of healthcheck since reaching systemd means the kernel booted successfully. Closes: fedora-iot#180 Co-authored-by: Cursor <cursoragent@cursor.com>
DRY up get_fallback_at and get_rollback_trigger_at into a shared get_grub_bool_var helper. Fix unset_grub_var context message that was hardcoded to "boot_counter" for all keys. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Change greenboot-set-rollback-trigger.service to run when bootc update or rpm-ostree upgrade stages a deployment, instead of at next boot. The service is now RequiredBy=ostree-finalize-staged.service and ordered Before= it, matching the pattern used by the original bash greenboot's greenboot-grub2-set-counter.service. This means the rollback trigger and fallback grub variables are set immediately when an update is staged, not deferred to the next boot. Removed: ConditionNeedsUpdate, boot-time ordering (sysinit.target, systemd-update-done.service), WantedBy boot targets. Added: ConditionPathExists=/run/ostree-booted, RequiresMountsFor=/boot, PrivateMounts=yes, RemainAfterExit=yes. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
say-paul
force-pushed
the
add-fallback
branch
2 times, most recently
from
2af74e3 to
3be77be
Compare
Healthcheck no longer directly triggers boot-complete.target. Instead: healthcheck passes -> OnSuccess activates greenboot-success.target -> success target Requires=boot-complete.target. This ensures boot-complete.target is only reached through the greenboot success chain, and greenboot-success.target has no [Install] section. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes - #180