introduce initrc_nnp_daemon_domain interface and fix locate systemd service AVCs #2793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to init_nnp_daemon_domain interface. Helpful if you run shell commands in ExecStart
solves
avc: denied { nnp_transition } for pid=7848 comm="sh" scontext=system_u:system_r:initrc_t:s0 tcontext=system_u:system_r:locate_t:s0 tclass=process2 permissive=0
|
Cockpit tests failed for commit 9fe0a90. @martinpitt, @jelly, @mvollmer please check. |
|
I wonder what is the use case for having initrc domains today? |
|
When a packager uses a shell construct in ExecStart this is run in initrc. Yes, I know that this is not a good way of doing things, but we still have cases like this and it will take some time until we get rid of them |
|
@zpytela I fear that these constructs will be with us for a while, so it would be nice to have an interface for this |
|
@zpytela can you please have another look? If that's not okay for you then I'll try to find another solution for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you run shell commands in ExecStart this is needed. This is the case for our locate systemd service, so use it there