Skip to content

Conversation

eaibmz
Copy link

@eaibmz eaibmz commented Oct 2, 2025

/dev/sclp[0-9]* and /dev/vmcp[0-9]* are s390x-specific character devices which are unrelated to VFIO. Therefore, change the label back to device_t.

Fixes: 61939da ("Add support for /dev/vmcp and /dev/sclp")

Related issue: #2864

/dev/sclp[0-9]* and /dev/vmcp[0-9]* are s390x-specific character devices
which are unrelated to VFIO. Therefore, change the label back to device_t.

Fixes: 61939da ("Add support for /dev/vmcp and /dev/sclp")
Signed-off-by: Alexander Egorenkov <[email protected]>
@zpytela
Copy link
Contributor

zpytela commented Oct 2, 2025

@WOnder93 What do you think would be appropriate label for these device files? The current version was added in 61939da and b1f7f8e (plus a fix in 2ce8aee).

@WOnder93
Copy link
Member

WOnder93 commented Oct 2, 2025

/dev/sclp (I believe it doesn't have numbered suffixes, just a single device) is a simple ioctl-only device that supports just one ioctl. It's apparently used as a control device for the IBM SCLP terminal. Seems to be very niche and could probably have its own label.

/dev/vmcp (I think this one isn't numbered either) is for communicating with the "z/VM control program" (i.e. for z/VM virtual machines to communicate with the hypervisor). I'd say it's likewise pretty niche and could have its own label.

/dev/clp is also s390x-specific, but unrelated to /dev/sclp. It appears to be some control device for PCI bus on s390x machines. Likewise should probably have its own label.

Or they could all be misc_device_t (in the kernel they are all registered as a "misc" device), but that seems to be unused currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants