Set temporary no-stub resolv.conf file from NetworkManager as net_conf_t #2908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently NetworkManager writes /run/NetworkManager/no-stub-resolv.conf by using mkstemp(), which creates a temporary file name with a random suffix and then renames it. The policy doesn't handle this, and the file gets wrongly labeled as NetworkManager_var_run_t. NetworkManager is being updated to write the file with a fixed ".tmp" suffix here: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2298 Adapt the policy accordingly.
|
The changed NM in combination with this policy change (available for openSUSE here https://build.opensuse.org/project/show/home:jsegitz:branches:security:SELinux_1248136) fixes the issue and the file has the proper label |
|
LGTM, together with the change in nm it is going to prevent many future misconfigurations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently NetworkManager writes
/run/NetworkManager/no-stub-resolv.confby usingmkstemp(), which creates a temporary file name with a random suffix and then renames it. The policy doesn't handle this, and the file gets wrongly labeled asNetworkManager_var_run_t.NetworkManager is being updated to write the file with a fixed ".tmp" suffix here:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2298
Adapt the policy accordingly.