Skip to content

Commit

Permalink
Merge pull request #1127 from fedspendingtransparency/staging
Browse files Browse the repository at this point in the history
6.0.6 Data Lab and Citizen's Guide Release
  • Loading branch information
xjackk authored Oct 8, 2019
2 parents 19fc859 + 958e924 commit 89bfe61
Show file tree
Hide file tree
Showing 13 changed files with 6,605 additions and 540 deletions.
2 changes: 1 addition & 1 deletion assets/ffg/components/glossary/glossary.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion assets/ffg/spending/categories.js

Large diffs are not rendered by default.

1,030 changes: 519 additions & 511 deletions assets/js/dendrogram.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions citizens-guide/src/components/glossary/glossary.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ function resizeTermListDiv() {
}

function onFfgPage() {
if (window.location.pathname.indexOf('americas-finance-guide') === -1 && window.location.host.indexOf('localhost') === -1) {
if (window.location.pathname.indexOf('americas-finance-guide') === -1) {
return false;
}

Expand All @@ -219,7 +219,7 @@ function showGlossary(el) {
}

if (!onFfgPage()) {
window.location = 'https://' + window.location.host + '/americas-finance-guide/?glossary';
window.location = 'https://' + window.location.host + '/americas-finance-guide/index.html?glossary';
return;
}

Expand Down
39 changes: 14 additions & 25 deletions citizens-guide/src/spending/categories/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { byYear } from '../data-spending';
import { drawChart as barChart } from './bar/chart';
import colors from '../../globalSass/colors.scss';
import { establishContainer } from '../../utils';
import Mapping from "../../../../_data/object_mapping.yml";

const d3 = { select, selectAll },
chartTitle = d3.select('h2.chart-title .title-text'),
Expand All @@ -13,7 +14,7 @@ const d3 = { select, selectAll },

let svg,
config = {
data: byYear(2018),
data: byYear(Mapping.current_fy.value),
sectionColor: colors.colorSpendingPrimary,
dataType: 'category',
accessibilityAttrs : {
Expand Down Expand Up @@ -58,41 +59,29 @@ function showMore() {

function changeDataTypeClickFunction(){
d3.select('#toggle-spending-data-type')
.on('click', function () {
const dataController = d3.select("#spending-chart-toggle"),
curData = dataController.attr('data-active');

let dataType = curData === 'function' ? 'agency' : 'function';
changeDataType(dataType);
});
.on('click', function () {
let dataType;
const dataController = d3.select("#spending-chart-toggle"),
curData = dataController.attr('data-active');

d3.select('.spending-chart-toggle__label--categories')
.on('click', function(){
const dataType = 'function';
if (curData === 'category' || curData === 'function') {
dataType = 'agency';
changeDataType(dataType);
});
d3.select('.spending-chart-toggle__label--agency')
.on('click', function(){
const dataType = 'agency';
} else {
dataType = 'category';
changeDataType(dataType);
});
}
});
}

function changeDataType(dataType){
const dataController = d3.select("#spending-chart-toggle"),
curData = dataController.attr('data-active');

if(dataType === curData){
return;
}

const dataController = d3.select("#spending-chart-toggle");
config.dataType = dataType;
dataController.attr('data-active', dataType);
initChart();
}

function spendingIndexClickFunctions() {

d3.select('#filter-by-name')
.on('input', function () {
const v = this.value.toLowerCase(),
Expand Down Expand Up @@ -130,7 +119,7 @@ export function init(_config){
}

spendingIndexClickFunctions();
if(config.dataType){
if (config.dataType) {
changeDataTypeClickFunction();
}
initSection();
Expand Down
5,659 changes: 5,659 additions & 0 deletions data-lab-data/accounts_obligations_link_update_FY19Q3.csv

Large diffs are not rendered by default.

336 changes: 336 additions & 0 deletions documentation/release-notes/6.0.0.md

Large diffs are not rendered by default.

18 changes: 18 additions & 0 deletions documentation/release-notes/6.0.1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Release notes - Data Analytics (Data Lab) - Version R6.0.1 - Colleges and Universities Patch Release


| Ticket | Description |
|---------------- | -------- |
| https://federal-spending-transparency.atlassian.net/browse/DA-3327 | Fedscope (Federal Employees Analysis)- choices for occupation type dynamically update based on selected agency |
| https://federal-spending-transparency.atlassian.net/browse/DA-3881 | Develop 404 page based on approved mockup |
| https://federal-spending-transparency.atlassian.net/browse/DA-3882 | create custom event for resources in nav and page |
| https://federal-spending-transparency.atlassian.net/browse/DA-4170 | 508 - Add unique ID tags to C&U visualizations |
| https://federal-spending-transparency.atlassian.net/browse/DA-4254 | Map mobile view - cant use finger on individual school bubbles |
| https://federal-spending-transparency.atlassian.net/browse/DA-4270 | C&U - Mobile - Search Box for Map, Agencies, and Sunburst Not Working Correctly |
| https://federal-spending-transparency.atlassian.net/browse/DA-4316 | C&U - 02 Alma Mater - Default Map Search List to Alphabetical Order |
| https://federal-spending-transparency.atlassian.net/browse/DA-4375 | C&U - IE Bubble Chart When Zoomed is Covering Next Section on Scroll |
| https://federal-spending-transparency.atlassian.net/browse/DA-4382 | Hero image not centrally aligned |
| https://federal-spending-transparency.atlassian.net/browse/DA-4392 | Sunburst - Solve Text Wrapping issues |
| https://federal-spending-transparency.atlassian.net/browse/DA-4430 | Create Google Analytics event(s) in C&U |
| https://federal-spending-transparency.atlassian.net/browse/DA-4501 | C&U - Download Button in Wrong Place on IE |
| https://federal-spending-transparency.atlassian.net/browse/DA-4512 | Fix Reddit Link |
6 changes: 6 additions & 0 deletions documentation/release-notes/6.0.2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Release notes - Data Analytics (Data Lab) - Version R6.0.2 - Security Patch Release


| Ticket | Description |
|---------------- | -------- |
| https://federal-spending-transparency.atlassian.net/browse/DA-4570 | Security fixes |
6 changes: 6 additions & 0 deletions documentation/release-notes/6.0.3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Release notes - Data Analytics (Data Lab) - Version R6.0.3 - Patch Release (Sprint 60)

| Ticket | Description |
|---------------- | -------- |
| https://federal-spending-transparency.atlassian.net/browse/DA-4377 | Update CU Social Share Options |
| https://federal-spending-transparency.atlassian.net/browse/DA-4424 | Map mobile view - Difficult to use finger on individual school bubbles |
1 change: 1 addition & 0 deletions documentation/release-notes/6.0.4.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
| https://federal-spending-transparency.atlassian.net/browse/CG-1624 | Social Media Sharing is broken in Firefox |

### Stories

| Ticket | Description |
|---------------- | -------- |
| https://federal-spending-transparency.atlassian.net/browse/CG-1541 | update all instances of country comparison to use public download files |
Expand Down
32 changes: 32 additions & 0 deletions documentation/release-notes/6.0.5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Release notes - Citizens Guide - Version R6.0.5 - AFG Refresh Patch Release (no Data Lab tickets)

### Bugs

| Ticket | Description |
|---------------- | -------- |
| https://federal-spending-transparency.atlassian.net/browse/CG-1548 | Anecdotes do not open in Edge |
| https://federal-spending-transparency.atlassian.net/browse/CG-1604 | Mobile - Deficit & Debt - Dots are clunky |


### Stories

| Ticket | Description |
|---------------- | -------- |
| https://federal-spending-transparency.atlassian.net/browse/CG-1540 | Remove non-public data files. |
| https://federal-spending-transparency.atlassian.net/browse/CG-1577 | Ensure that no years are hard-coded (e.g. 2018) |
| https://federal-spending-transparency.atlassian.net/browse/CG-1581 | Dev - update front matter on top of each page |
| https://federal-spending-transparency.atlassian.net/browse/CG-1607 | Remove hard-coded annual numbers |
| https://federal-spending-transparency.atlassian.net/browse/CG-1630 | [Overview] Update numbers/objects in code with variables (Jekyll-dependent) |
| https://federal-spending-transparency.atlassian.net/browse/CG-1663 | [Revenue] Update numbers/objects in code with variables (Jekyll-dependent) |
| https://federal-spending-transparency.atlassian.net/browse/CG-1664 | [Spending] Update numbers/objects in code with variables (Jekyll-dependent) |
| https://federal-spending-transparency.atlassian.net/browse/CG-1665 | [Deficit] Update numbers/objects in code with variables (Jekyll-dependent) |
| https://federal-spending-transparency.atlassian.net/browse/CG-1666 | [Debt] Update numbers/objects in code with variables (Jekyll-dependent) |
| https://federal-spending-transparency.atlassian.net/browse/CG-1669 | Color Consistency - Debt Country Comparison page, 'Revenue' box is old blue color |
| https://federal-spending-transparency.atlassian.net/browse/CG-1691 | Move glossary csv to a more standardized location |
| https://federal-spending-transparency.atlassian.net/browse/CG-1701 | Fix Dot Charts on Landing Pages in Mobile |
| https://federal-spending-transparency.atlassian.net/browse/CG-1702 | Revenue Trends & Spending Trends chart in mobile showing NaN when using higher numbers from dummy dataset |
| https://federal-spending-transparency.atlassian.net/browse/CG-1709 | in trends charts, when using fiscal years 2015-2019, figure out why two lines appear in the charts where there should only be one |
| https://federal-spending-transparency.atlassian.net/browse/CG-1713 | Color Consistency - Spending And GDP page, revenue dots are the old blue color |
| https://federal-spending-transparency.atlassian.net/browse/CG-1717 | fix the links in the Data Sources accordions, must use the variables from the .yml file |
| https://federal-spending-transparency.atlassian.net/browse/CG-1753 | add new variables to the .yml for the number of dots in each chapter's dot chart, and add the variable to the html |
| https://federal-spending-transparency.atlassian.net/browse/CG-1754 | catch-all ticket for small issues we find with the yml/html this sprint |
10 changes: 10 additions & 0 deletions documentation/release-notes/6.0.6.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Release notes: Version R6.0.6 (Citizen Guide and Data Lab Tickets)

## Fixes
***

| Ticket | Description |
|---------------- | -------- |
| https://federal-spending-transparency.atlassian.net/browse/CG-1828 | fixed bug where category toggle stops working on subsequent clicks |
| n/a | Glossary fix in FIR Infrastructure |
| https://federal-spending-transparency.atlassian.net/browse/DA-4752 | Added FY19 Q3 to Federal Account Explorer Dendrogram Visualization |

0 comments on commit 89bfe61

Please sign in to comment.