Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV - 11970: Fix Date Range dropdown visible height is too small #4482

Open
wants to merge 6 commits into
base: qat
Choose a base branch
from

Conversation

jdhfrb
Copy link

@jdhfrb jdhfrb commented Feb 5, 2025

High level description:

Fix Date Range dropdown visible height is too small

Technical details:

Overflow styling for classname "category-filter" prevented the date range dropdown to show more than a few options. Adding classnmae "time-period" to the TimePeriod component allows us to modify the parent "category-filter" styling to apply the styles when needed but not when the the child "time-period" class is present.

JIRA Ticket:
DEV-11970

The following are ALL required for the PR to be merged:

Author:

  • Linked to this PR in JIRA ticket
  • Scheduled demo including Design/Testing/Front-end OR Provided instructions for testing in JIRA and PR if applicable
  • Verified cross-browser compatibility: Chrome, Safari, Firefox, Edge
  • Verified mobile/tablet/desktop/monitor responsiveness
  • Verified that this PR does not create any new accessibility issues (via Axe Chrome extension)
  • Added Unit Tests for helper functions, reducers, models and Container/Component Interactivity Expectations if applicable React Testing Library
  • API contract updated if applicable
  • Component Library Integration Status Report updated if applicable

Reviewer(s):

  • Design review complete if applicable
  • API #1234 merged concurrently if applicable
  • Code review complete

@nick-torres
Copy link
Contributor

merge in qat to resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants