GUI: Improved image caching logic to reduce memory usage. - #1042
Merged
Conversation
mokurin000
suggested changes
May 26, 2026
mokurin000
suggested changes
May 26, 2026
shinnkka
commented
May 26, 2026
| self.w_h_ratio = 1.0 | ||
|
|
||
| self._device_pixel_ratio = QGuiApplication.instance().devicePixelRatio() | ||
| self._pixmap_cache_limit_kb = 128 * 1024 |
Contributor
Author
There was a problem hiding this comment.
这是128*1024kb,你希望缩小到32*1024kb吗（
cosven
reviewed
May 26, 2026
cosven
left a comment
cosven
left a comment
Member
There was a problem hiding this comment.
这个 cache 能不能抽出一个公共类出来呢，看着上下两段代码似乎差不多的样子
shinnkka
marked this pull request as draft
May 26, 2026 16:36
shinnkka
marked this pull request as ready for review
May 26, 2026 23:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
after:
