enhance: locale matching distance, fallback - #1043
Merged
Merged
Conversation
Contributor
Author
|
@cosven 我重写了一份新的 fallback 逻辑,并且适当调整了 distance 阈值 |
cosven
reviewed
May 28, 2026
Comment on lines
+31
to
+35
| return langcodes.closest_supported_match( | ||
| desired_language=locale, | ||
| supported_languages=supported_lang, | ||
| max_distance=200, | ||
| ) |
Member
There was a problem hiding this comment.
With max_distance=200, unrelated languages tie against the supported set and langcodes picks the first directory returned by os.listdir. In this PR worktree, supported locales are ["ja-JP", "zh-CN", "en-US"], so t("playlist", locale="ko-KR") and locale="ru" return Japanese instead of falling back to English. The old behavior returned None from closest_supported_match, then loaded the fallback chain. This needs an explicit fallback policy for unrelated languages, or a lower/conditional threshold, before enabling the optional langcodes path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default max_distance of
langcodes.closest_supported_match25 is insufficient to match various languages.This PR also added a fallback method to make
langcodesan optional dependency.It's now gated behind the
i18n-matchoptional group.